Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecated methods #333

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Resolve deprecated methods #333

merged 6 commits into from
Feb 10, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Related with

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Introduction of array_change_key_case function
    The use of array_change_key_case function has been expanded across the codebase, providing a more streamlined way of managing array data. This function essentially standardizes the formatting of array keys.

  • Replacement of normalizeRowKeyCase function
    Various methods such as loadTableIndexes, findConstraints, findUniqueIndexes, findColumns, and loadTableConstraints, have had the normalizeRowKeyCase function replaced with the array_change_key_case function. This change simplifies the code, making it easier to read and maintain.

  • Modification in getCacheKey method
    The method used to generate cache keys has been modified. The existing $this->getRawTableName($name) call has been replaced with $this->db->getQuoter()->getRawTableName($name). This change brings more accuracy in generating cache keys by implementing a direct call to the database's Quoter on getting raw table names.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (089f252) 100.00% compared to head (a635f58) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #333   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       241       241           
===========================================
  Files             16        16           
  Lines            694       694           
===========================================
  Hits             694       694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
@Tigrov Tigrov merged commit de75fbb into master Feb 10, 2024
63 of 67 checks passed
@Tigrov Tigrov deleted the deprecate-schema-methods branch February 10, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants